Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix macOS typo #44

Merged
merged 1 commit into from
Feb 3, 2025
Merged

chore: fix macOS typo #44

merged 1 commit into from
Feb 3, 2025

Conversation

Kha1r0
Copy link

@Kha1r0 Kha1r0 commented Feb 3, 2025

fix MacOS typo to macOS

Checklist

Formalities:

  • PR targets staging, if compare branch is chore/* or feat/*
  • PR title is formatted as a commit
  • New functions are commented in the source file
  • Notes are added to wiki

@Kha1r0 Kha1r0 self-assigned this Feb 3, 2025
@Kvnstrck Kvnstrck added the chore Something that doesnt add functionality but is required to do label Feb 3, 2025
D3vZro
D3vZro approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@D3vZro D3vZro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an overkill ...

@Kha1r0
Copy link
Author

Kha1r0 commented Feb 3, 2025

Lies

@Kha1r0 Kha1r0 added this to the Iteration 4 milestone Feb 3, 2025
MoPhliFra
MoPhliFra reviewed Feb 3, 2025
View reviewed changes
.github/pull_request_template.md
@@ -13,7 +13,7 @@ Closes <!-- ?? -->
#### Quality assurance:
- Manual build and unit/component testing:
- [ ] Linux
- [ ] MacOS
- [ ] macOS
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great Code!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Kha1r0 Kha1r0 merged commit e844e07 into staging Feb 3, 2025
1 of 2 checks passed
@Kvnstrck Kvnstrck deleted the chore/macOS-typo branch February 4, 2025 08:20
@D3vZro
Copy link
Collaborator

D3vZro commented Feb 5, 2025

PR has been reverted by force-push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoPhliFra MoPhliFra MoPhliFra approved these changes

@D3vZro D3vZro D3vZro approved these changes

@Kvnstrck Kvnstrck Kvnstrck approved these changes

@nicosvv nicosvv nicosvv approved these changes

Assignees

@Kha1r0 Kha1r0

Labels
chore Something that doesnt add functionality but is required to do
Projects
None yet
Milestone
Iteration 4
Development

Successfully merging this pull request may close these issues.
5 participants
@Kha1r0 @D3vZro @MoPhliFra @Kvnstrck @nicosvv